Support TagMacro parameter substitution for polymorphic function types on Scala 3 #576
Open
Exceluyi wants to merge 3 commits into
Open
Support TagMacro parameter substitution for polymorphic function types on Scala 3 #576Exceluyi wants to merge 3 commits into
Exceluyi wants to merge 3 commits into
Conversation
Author
|
pls review when you have time @neko-kai @pshirshov |
Member
|
That's a lot of changes all around the codebase & in the runtime. Can you substantiate them? You can also try regenerating with Codex - that produces much smaller & focused diffs. |
Author
how do suppose i reduce the diff @neko-kai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
TagMacrosubstitution for Scala 3 polymorphic function types where type parameters are hidden inside structural method refinements.Previously, weak type references inside refinement member signatures (including polymorphic method signatures) were not fully substituted, causing
Tagderivation to fail for types like:[A] => AppF[A] => InjF[Either[CustomError, A]]Tests
TagTestfor:SharedTagProgressionTest:/fixes #404
/claim #404